Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: io/formats/html.py: refactor #23818

Merged
merged 5 commits into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@simonjayhawkins
Copy link
Member

commented Nov 20, 2018

  • [ n/a] follow-on from #22726
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

remove max_rows and max_cols from HTMLFormatter as truncation is now handled by DataFrameFormatter

note: this PR should be orthogonal to #22655

@pep8speaks

This comment has been minimized.

Copy link

commented Nov 20, 2018

Hello @simonjayhawkins! Thanks for submitting the PR.

@codecov

This comment has been minimized.

Copy link

commented Nov 20, 2018

Codecov Report

Merging #23818 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23818      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         161      161              
  Lines       51500    51494       -6     
==========================================
- Hits        47528    47522       -6     
  Misses       3972     3972
Flag Coverage Δ
#multiple 90.68% <100%> (-0.01%) ⬇️
#single 42.31% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/html.py 97.63% <100%> (-0.05%) ⬇️
pandas/io/formats/format.py 97.76% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ae454...f1dbb54. Read the comment docs.

@gfyoung
Copy link
Member

left a comment

Are these classes in anyway considered user-facing? If not, LGTM.

cc @jreback @WillAyd

Show resolved Hide resolved pandas/io/formats/html.py Outdated
Show resolved Hide resolved pandas/io/formats/html.py Outdated
@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

these changes are ok, though @simonjayhawkins pls add a note anyhow in api breaking changes (they are private but just a notice)

@simonjayhawkins

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2018

@gfyoung @jreback note about api breaking change has been added to whatsnew

@gfyoung
Copy link
Member

left a comment

@jreback jreback added this to the 0.24.0 milestone Nov 27, 2018

@jreback jreback merged commit 5e0c392 into pandas-dev:master Nov 27, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20181122.13 succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

@simonjayhawkins simonjayhawkins deleted the simonjayhawkins:to-html-refactor branch Nov 27, 2018

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.