Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
ENH: ExtensionArray.repeat #24349
@@ Coverage Diff @@ ## master #24349 +/- ## ========================================== - Coverage 92.29% 92.29% -0.01% ========================================== Files 162 162 Lines 51806 51813 +7 ========================================== + Hits 47815 47821 +6 - Misses 3991 3992 +1
@@ Coverage Diff @@ ## master #24349 +/- ## ========================================== + Coverage 92.29% 92.29% +<.01% ========================================== Files 162 162 Lines 51806 51815 +9 ========================================== + Hits 47815 47824 +9 Misses 3991 3991
Added a fixture to parametrize the test across ExtensionArray.repeat and Series.repeat. I don't think there's any code duplication that could be removed. Series needs to handle repeating the index, and just dispatches to `._values` for repeating the array.…
On Wed, Dec 19, 2018 at 8:26 AM Jeff Reback ***@***.***> wrote: do we have interactions with our other defintiions of this series.py and indexes/base.py? maybe create an issue to investigate this code duplication (same for searchsorted) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24349 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIk2RNEBe9veEuB-kySoCs0uQiJBSks5u6kyugaJpZM4ZaLkl> .
ExtensionArray is an auto summary, so these will be added automatically. Though now that I think about it, it won't have the "private" methods like _from_sequnce, since numpydoc / autodoc excludes items starting with an `_`. But I guess they'll be looking at the source / GitHub anyway.…
On Thu, Dec 20, 2018 at 8:38 AM Jeff Reback ***@***.***> wrote: ***@***.**** approved this pull request. these methods are in api.rst? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24349 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIjlQR2W_pg1KackhRkPJLVs7c5-Cks5u66DhgaJpZM4ZaLkl> .
Dec 20, 2018
referenced this pull request
Dec 22, 2018
added a commit
this pull request
Feb 28, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.