Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: ExtensionArray.repeat #24349

Merged
merged 3 commits into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@TomAugspurger
Copy link
Contributor

commented Dec 19, 2018

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Dec 19, 2018

@pep8speaks

This comment has been minimized.

Copy link

commented Dec 19, 2018

Hello @TomAugspurger! Thanks for submitting the PR.

@@ -987,7 +987,8 @@ update the ``ExtensionDtype._metadata`` tuple to match the signature of your

**Other changes**

- ``ExtensionArray`` has gained the abstract methods ``.dropna()`` (:issue:`21185`)

This comment has been minimized.

Copy link
@TomAugspurger

TomAugspurger Dec 19, 2018

Author Contributor

This method isn't abstract.

def repeat(self, repeats, axis=None):
"""
Repeat elements of an array.

This comment has been minimized.

Copy link
@TomAugspurger

TomAugspurger Dec 19, 2018

Author Contributor

Need a versionadded. Will do that on merge maybe, unless there are other comments on the implementation.

@codecov

This comment has been minimized.

Copy link

commented Dec 19, 2018

Codecov Report

Merging #24349 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24349      +/-   ##
==========================================
- Coverage   92.29%   92.29%   -0.01%     
==========================================
  Files         162      162              
  Lines       51806    51813       +7     
==========================================
+ Hits        47815    47821       +6     
- Misses       3991     3992       +1
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 43% <14.28%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/base.py 97.53% <100%> (+0.11%) ⬆️
pandas/util/testing.py 87.48% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c230f29...757b49b. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Dec 19, 2018

Codecov Report

Merging #24349 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24349      +/-   ##
==========================================
+ Coverage   92.29%   92.29%   +<.01%     
==========================================
  Files         162      162              
  Lines       51806    51815       +9     
==========================================
+ Hits        47815    47824       +9     
  Misses       3991     3991
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 42.99% <14.28%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/base.py 97.53% <100%> (+0.11%) ⬆️
pandas/core/reshape/merge.py 94.3% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c230f29...a16c253. Read the comment docs.

@TomAugspurger TomAugspurger referenced this pull request Dec 19, 2018

Merged

REF: DatetimeLikeArray #24024

7 of 12 tasks complete
@jreback

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2018

do we have interactions with our other defintiions of this series.py and indexes/base.py? maybe create an issue to investigate this code duplication (same for searchsorted)

@TomAugspurger

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2018

@TomAugspurger

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

All green.

@jreback
Copy link
Contributor

left a comment

these methods are in api.rst?

@TomAugspurger

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

@jreback jreback merged commit 5d134ec into pandas-dev:master Dec 20, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20181219.31 succeeded
Details

@TomAugspurger TomAugspurger deleted the TomAugspurger:ea-repeat branch Jan 2, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.