DOC: fix to_numpy explanation for tz aware data #24595
Conversation
| 2. A ``datetime64[ns]`` -dtype :class:`ndarray`, where the values have | ||
| been converted to UTC and the timezone discarded | ||
|
|
||
| Timezones may be preserved with ``dtype=object`` |
There was a problem hiding this comment.
@TomAugspurger can you double check here? But it seems this section was duplicated (added each time by two related PRs, probably some merging/rebasing left-over)
| 2. A ``datetime64[ns]`` -dtype :class:`ndarray`, where the values have | ||
| been converted to UTC and the timezone discarded | ||
|
|
||
| Timezones may be preserved with ``dtype=object`` |
| @@ -2425,21 +2425,25 @@ a convert on an aware stamp. | |||
| .. note:: | |||
|
|
|||
| Using :meth:`Series.to_numpy` on a ``Series``, returns a NumPy array of the data. | |||
| These values are converted to UTC, as NumPy does not currently support timezones (even though it is *printing* in the local timezone!). | |||
| NumPy does not currently support timezones (even though it is *printing* in the local timezone!), | |||
There was a problem hiding this comment.
I don't think the statement about printing is true anymore.
Codecov Report
@@ Coverage Diff @@
## master #24595 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 166 166
Lines 52497 52497
=======================================
Hits 48490 48490
Misses 4007 4007
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24595 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 166 166
Lines 52497 52497
=======================================
Hits 48490 48490
Misses 4007 4007
Continue to review full report at Codecov.
|
|
thanks @jorisvandenbossche |
|
Tom actually put a review comment, but OK, will fix another time :) |
Some clean-up now
to_numpypreserves timezone and no longer converts to UTC datetime64 by default (after #24024), the example in timeseries.rst was failing due to that.