Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Categorical ops defer to DataFrame; broken off of #24282 #24630

Merged
merged 2 commits into from Jan 5, 2019

Conversation

Projects
None yet
2 participants
@jbrockmendel
Copy link
Member

commented Jan 4, 2019

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@jreback
Copy link
Contributor

left a comment

need a whatsnew note (can put with one of the other notes in ops and alignment) - does this close anything?

@codecov

This comment has been minimized.

Copy link

commented Jan 5, 2019

Codecov Report

Merging #24630 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24630      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52395    52395              
==========================================
- Hits        48403    48402       -1     
- Misses       3992     3993       +1
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.41% <100%> (ø) ⬆️
pandas/util/testing.py 88% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb31b2b...005d35d. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jan 5, 2019

Codecov Report

Merging #24630 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24630   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52395    52395           
=======================================
  Hits        48403    48403           
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.41% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb31b2b...c5374a2. Read the comment docs.

@jbrockmendel

This comment has been minimized.

Copy link
Member Author

commented Jan 5, 2019

Will add what’s new and check on issues

@jreback jreback added this to the 0.24.0 milestone Jan 5, 2019

@jreback

jreback approved these changes Jan 5, 2019

@jreback jreback merged commit dc703ce into pandas-dev:master Jan 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190105.3 succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2019

thanks!

@jbrockmendel jbrockmendel deleted the jbrockmendel:cat_ops branch Jan 5, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.