#25707 - Fixed flakiness in stata write test

[gwrome]

This is my first contribution, so please be gentle.

For future reference, this error occurs when the two files are written in different minutes. I couldn't break the comparison by feeding the test datetime objects that only changed the seconds, so I assume only the date, hours, and minutes, are encoded.

Anyway, we can't pass False as a keyword argument for time_stamp. It defaults to None, which internally uses the current timestamp, but otherwise expects a datetime.

For testing purposes, it suffice to pass the same arbitrary timestamp as a keyword. That way it encodes the same timestamp into each file, regardless of when the test runs and how long it takes.

Instead of False, we could use a keyword argument like this: {'time_stamp': pd.to_datetime('2019-01-01 00:00')}

[codecov]

Codecov Report

Merging #25714 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25714   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         172      172           
  Lines       52967    52967           
=======================================
  Hits        48332    48332           
  Misses       4635     4635

Flag	Coverage Δ
#multiple	89.82% <ø> (ø)	⬆️
#single	41.74% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf7fce...af9ec8e. Read the comment docs.

[TomAugspurger]

Thanks @gwrome! Nice job, and sorry about misleading you in the issue with the time_stamp argument type.

[gwrome]

You're welcome, glad I could help!