Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Test doctests in pandas/core/groupby/groupby.py #26255

Merged
merged 4 commits into from May 1, 2019

Conversation

Projects
None yet
3 participants
@HyukjinKwon
Copy link
Contributor

commented May 1, 2019

  • closes #26254
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #26255 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26255      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52384    52384              
==========================================
- Hits        48184    48179       -5     
- Misses       4200     4205       +5
Flag Coverage Δ
#multiple 90.52% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby/groupby.py 97.23% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.61% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eff627...38c2269. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #26255 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26255      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.02%     
==========================================
  Files         175      175              
  Lines       52384    52386       +2     
==========================================
- Hits        48184    48180       -4     
- Misses       4200     4206       +6
Flag Coverage Δ
#multiple 90.52% <ø> (-0.01%) ⬇️
#single 40.72% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby/groupby.py 97.23% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/base.py 97.98% <0%> (-0.22%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.61% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eff627...9b2dd46. Read the comment docs.

@jreback

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

this is probably a good fix, but we are not testing this currently, you need update in ci/code_checks (and see if this passes)

    MSG='Doctests generic.py' ; echo $MSG
    pytest -q --doctest-modules pandas/core/generic.py \
        -k"-_set_axis_name -_xs -describe -droplevel -groupby -interpolate -pct_change -pipe -reindex -reindex_axis -to_json -transpose -values -xs -to_clipboard"
    RET=$(($RET + $?)) ; echo $MSG "DONE"
@HyukjinKwon

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Thanks for your guidance.

Show resolved Hide resolved ci/code_checks.sh Outdated

HyukjinKwon added some commits May 1, 2019

@HyukjinKwon HyukjinKwon changed the title DOC: Fix doctests in GroupBy.mean() to check output DOC: Test doctests in pandas/core/groupby/groupby.py May 1, 2019

@datapythonista
Copy link
Member

left a comment

lgtm

Feel free to fix the doctests in cumcount, describe, pipe in this PR if you want. But happy to merge this and take care of them later.

@jreback jreback added this to the 0.25.0 milestone May 1, 2019

@jreback jreback merged commit 4df308f into pandas-dev:master May 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

thanks for the patch @HyukjinKwon keep em coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.