Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upDOC: Test doctests in pandas/core/groupby/groupby.py #26255
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
May 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #26255 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 175 175
Lines 52384 52384
==========================================
- Hits 48184 48179 -5
- Misses 4200 4205 +5
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
May 1, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #26255 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.02%
==========================================
Files 175 175
Lines 52384 52386 +2
==========================================
- Hits 48184 48180 -4
- Misses 4200 4206 +6
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
this is probably a good fix, but we are not testing this currently, you need update in ci/code_checks (and see if this passes)
|
jreback
added
Docs
Testing
labels
May 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for your guidance. |
datapythonista
reviewed
May 1, 2019
ci/code_checks.sh Outdated
HyukjinKwon
added some commits
May 1, 2019
HyukjinKwon
changed the title
DOC: Fix doctests in GroupBy.mean() to check output
DOC: Test doctests in pandas/core/groupby/groupby.py
May 1, 2019
datapythonista
approved these changes
May 1, 2019
|
lgtm Feel free to fix the doctests in cumcount, describe, pipe in this PR if you want. But happy to merge this and take care of them later. |
jreback
added this to the 0.25.0 milestone
May 1, 2019
jreback
merged commit 4df308f
into
pandas-dev:master
May 1, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
|
thanks for the patch @HyukjinKwon keep em coming! |
HyukjinKwon commentedMay 1, 2019
•
edited
git diff upstream/master -u -- "*.py" | flake8 --diff