Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: Using cpplint from conda-forge #26693

Merged
merged 3 commits into from Jun 7, 2019
Merged

DEPS: Using cpplint from conda-forge #26693

merged 3 commits into from Jun 7, 2019

Conversation

datapythonista
Copy link
Member

Follow up of #26691. cpplint was installed from pip, but it's now available in conda-forge.

CC: @TomAugspurger

@datapythonista datapythonista added the Dependencies Required and optional dependencies label Jun 6, 2019
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jun 6, 2019 via email

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #26693 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26693      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50694    50694              
==========================================
- Hits        46581    46577       -4     
- Misses       4113     4117       +4
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.92% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c6c22...7dbda9d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #26693 into master will decrease coverage by 49.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26693       +/-   ##
===========================================
- Coverage   91.88%   41.91%   -49.98%     
===========================================
  Files         174      174               
  Lines       50701    50701               
===========================================
- Hits        46588    21250    -25338     
- Misses       4113    29451    +25338
Flag Coverage Δ
#multiple ?
#single 41.91% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/sparse/scipy_sparse.py 10.14% <0%> (-89.86%) ⬇️
pandas/core/tools/numeric.py 10.14% <0%> (-89.86%) ⬇️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649ad5c...5f514cc. Read the comment docs.

@gfyoung
Copy link
Member

gfyoung commented Jun 6, 2019

@datapythonista : Looks like Azure is having some weird issues with your commits.

@datapythonista
Copy link
Member Author

@gfyoung I reported it to the azure-pipelines people, and they say it's GitHub who sometimes send the webhook before the repo is replicated in their servers, and that causes this error, that appears randomly. I was told they are working on a fix. Merging master to relaunch the CI fixed it.

@TomAugspurger TomAugspurger merged commit 35264ca into pandas-dev:master Jun 7, 2019
@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants