Skip to content

Conversation

@xcz011
Copy link
Contributor

@xcz011 xcz011 commented Jun 19, 2019

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #26936 into master will decrease coverage by 50.76%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26936       +/-   ##
===========================================
- Coverage   91.87%   41.11%   -50.77%     
===========================================
  Files         180      180               
  Lines       50743    50744        +1     
===========================================
- Hits        46620    20861    -25759     
- Misses       4123    29883    +25760
Flag Coverage Δ
#multiple ?
#single 41.11% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/_ranges.py 53.33% <100%> (-45.32%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/plotting/_matplotlib/__init__.py 0% <0%> (-100%) ⬇️
pandas/io/gcs.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/io/s3.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47947a...96aa1cf. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #26936 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26936      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       50743    50744       +1     
==========================================
- Hits        46620    46617       -3     
- Misses       4123     4127       +4
Flag Coverage Δ
#multiple 90.46% <100%> (ø) ⬆️
#single 41.11% <100%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/_ranges.py 98.66% <100%> (+0.01%) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47947a...96aa1cf. Read the comment docs.

@gfyoung gfyoung added the Typing type annotations, mypy/pyright type checking label Jun 20, 2019
@gfyoung gfyoung requested a review from WillAyd June 20, 2019 20:50
@jreback jreback added this to the 0.25.0 milestone Jun 21, 2019
@jreback
Copy link
Contributor

jreback commented Jun 21, 2019

lgtm. @WillAyd

@WillAyd WillAyd merged commit fa92585 into pandas-dev:master Jun 21, 2019
@WillAyd
Copy link
Member

WillAyd commented Jun 21, 2019

Thanks!

@xcz011 xcz011 deleted the type_hint_pandas_core branch June 21, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants