Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix empty Series repr for subclasses #27001

Merged

Conversation

@jorisvandenbossche
Copy link
Member

commented Jun 22, 2019

Currently, the 'Series' name is hardcoded in the empty repr. This small patch ensures it uses the name of the class.

@codecov

This comment has been minimized.

Copy link

commented Jun 22, 2019

Codecov Report

Merging #27001 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27001      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 41.83% <0%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/format.py 97.91% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14874f...ca58557. Read the comment docs.

2 similar comments
@codecov

This comment has been minimized.

Copy link

commented Jun 22, 2019

Codecov Report

Merging #27001 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27001      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 41.83% <0%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/format.py 97.91% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14874f...ca58557. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 22, 2019

Codecov Report

Merging #27001 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27001      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         180      180              
  Lines       50774    50774              
==========================================
- Hits        46711    46707       -4     
- Misses       4063     4067       +4
Flag Coverage Δ
#multiple 90.63% <100%> (ø) ⬆️
#single 41.83% <0%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/format.py 97.91% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14874f...ca58557. Read the comment docs.

@@ -39,6 +39,9 @@ def test_subclass_unstack(self):

tm.assert_frame_equal(res, exp)

def test_subclass_empty_repr(self):

This comment has been minimized.

Copy link
@gfyoung

gfyoung Jun 22, 2019

Member

Reference PR number as comment below this

This comment has been minimized.

Copy link
@TomAugspurger

TomAugspurger Jun 22, 2019

Contributor

General question: if a PR is already passing, is it worth another commit and CI run just for this?

I'd prefer to just merge and be done with it.

This comment has been minimized.

Copy link
@jreback

jreback Jun 22, 2019

Contributor

yep that’s cool

@WillAyd WillAyd merged commit 8ea2d08 into pandas-dev:master Jun 25, 2019

12 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190622.10 succeeded
Details
pandas-dev.pandas (Checks) Checks succeeded
Details
pandas-dev.pandas (Docs) Docs succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
@WillAyd

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@jorisvandenbossche jorisvandenbossche deleted the jorisvandenbossche:series-empty-repr-subclass branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.