Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Panel Kludge from Pickle/Msgpack tests #27082

Merged
merged 14 commits into from Jun 27, 2019

Conversation

@WillAyd
Copy link
Member

commented Jun 27, 2019

@jreback @jbrockmendel

Recreated pickle file for 0.20.3 using Python 3.5.2 on Mac. Created msgpack file anew (previously 0.19 was last version tested)

Lots of follow ups can be done here including:

  • Automatically generating one of these files as part of build process
  • Decoupling script from test requirements (fixturization and break off)

Can also add more platforms / versions here as required but this should be a good starting point

@pep8speaks

This comment has been minimized.

Copy link

commented Jun 27, 2019

Hello @WillAyd! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-27 20:16:22 UTC
@jreback
Copy link
Contributor

left a comment

small change. can you add a note to whatnsew (use warning) at the top to indicate that we are no longer supporting pickle < 0.20.3; also add a note in io.rst

if _loose_version >= LooseVersion('0.18'):
from pandas import RangeIndex
index['range'] = RangeIndex(10)
from pandas import RangeIndex

This comment has been minimized.

Copy link
@jreback

jreback Jun 27, 2019

Contributor

can move this import to the top i think

@jreback jreback added this to the 0.25.0 milestone Jun 27, 2019

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

need a note for mspack as well.

.. warning::

``read_pickle`` and ``read_msgpack`` are only guaranteed backwards compatible back to
pandas version 0.20.3

This comment has been minimized.

Copy link
@jreback

jreback Jun 27, 2019

Contributor

can you add the issue number reference here

@@ -13,6 +13,11 @@ What's New in 0.25.0 (April XX, 2019)
`Panel` has been fully removed. For N-D labeled data structures, please
use `xarray <https://xarray.pydata.org/en/stable/>`_

.. warning::

``read_pickle`` and ``read_msgpack`` are only guaranteed backwards compatible back to

This comment has been minimized.

Copy link
@jreback

jreback Jun 27, 2019

Contributor

can you add the :func:`read_pickle` and same for msgpack

@@ -13,6 +13,11 @@ What's New in 0.25.0 (April XX, 2019)
`Panel` has been fully removed. For N-D labeled data structures, please
use `xarray <https://xarray.pydata.org/en/stable/>`_

.. warning::

This comment has been minimized.

Copy link
@jreback

jreback Jun 27, 2019

Contributor

also add this note in io.rst (or similar, doesn't need the issue number)

@jreback jreback merged commit 46cd7f0 into pandas-dev:master Jun 27, 2019

12 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190627.75 succeeded
Details
pandas-dev.pandas (Checks) Checks succeeded
Details
pandas-dev.pandas (Docs) Docs succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

thanks @WillAyd

@WillAyd WillAyd deleted the WillAyd:pickle-script-panel branch Jun 27, 2019

alimcmaster1 added a commit to alimcmaster1/pandas that referenced this pull request Jun 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.