Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix handling of ambiguous or nonexistent of start and end times in date_range #27088

Merged
merged 10 commits into from Jun 28, 2019

Conversation

@mroeschke
Copy link
Member

commented Jun 27, 2019

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Closing a FIXME note in the test suite.

@mroeschke mroeschke changed the title BUG: Fix ambiguous or nonexistent handling of date_range start and end times BUG: Fix handling of ambiguous or nonexistent of start and end times in date_range Jun 27, 2019

Matt Roeschke
Matt Roeschke
@@ -2133,6 +2136,8 @@ def _maybe_localize_point(ts, is_none, is_not_none, freq, tz):
is_not_none : argument that should not be None
freq : Tick, DateOffset, or None
tz : str, timezone object or None

This comment has been minimized.

Copy link
@jreback

jreback Jun 28, 2019

Contributor

of u feel like typing the args here would be great (or follow up done too)

Matt Roeschke

@jreback jreback added this to the 0.25.0 milestone Jun 28, 2019

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

lgtm. @mroeschke if you want to add some types great, otherwise pls merge.

@mroeschke mroeschke merged commit e9f9ca1 into pandas-dev:master Jun 28, 2019

14 checks passed

codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 91.83% (target 82%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190628.8 succeeded
Details
pandas-dev.pandas (Checks) Checks succeeded
Details
pandas-dev.pandas (Docs) Docs succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
@mroeschke

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Thanks. Will add typing in a future PR.

@mroeschke mroeschke deleted the mroeschke:raise_ambiguous_date_range_edge branch Jun 28, 2019

alimcmaster1 added a commit to alimcmaster1/pandas that referenced this pull request Jun 30, 2019

BUG: Fix handling of ambiguous or nonexistent of start and end times …
…in date_range (pandas-dev#27088)

* BUG: Raise AmbiguousTimeError for date_range with ambiguous start time.

* Clarify comment

* Add nonexistent tests

* xfail one case after discovered bug

* Add whatsnew issue number

* Missing backtick

* Misspelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.