Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame html repr: also follow min_rows setting #27991

Merged

Conversation

@jorisvandenbossche
Copy link
Member

commented Aug 18, 2019

Follow-up on #27095, where I forgot to apply this setting in the html repr as well.

Thoughts on including this in 0.25.1 or not? It's kind of a oversight of the 0.25 feature, but also an actual change of course in the user experience in the notebook.

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

I'm probably OK with backporting 0.25.1.

@jorisvandenbossche jorisvandenbossche added this to the 0.25.1 milestone Aug 19, 2019

@jorisvandenbossche

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

OK, added a whatsnew for 0.25.1 then

@TomAugspurger TomAugspurger merged commit ec3d786 into pandas-dev:master Aug 20, 2019

15 checks passed

codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 93.05% (target 82%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190820.13 succeeded
Details
pandas-dev.pandas (Checks) Checks succeeded
Details
pandas-dev.pandas (Docs) Docs succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_32bit) Linux py36_32bit succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Thanks!

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 20, 2019
jorisvandenbossche added a commit that referenced this pull request Aug 21, 2019
Backport PR #27991 on branch 0.25.x (DataFrame html repr: also follow…
… min_rows setting) (#28044)

* Backport PR #27991: DataFrame html repr: also follow min_rows setting

* fix return value
galuhsahid added a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
DataFrame html repr: also follow min_rows setting (pandas-dev#27991)
* DataFrame html repr: also follow min_rows setting

* add whatsnew
gabriellm1 added a commit to gabriellm1/pandas that referenced this pull request Aug 27, 2019
DataFrame html repr: also follow min_rows setting (pandas-dev#27991)
* DataFrame html repr: also follow min_rows setting

* add whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.