Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
BUG/TST: fix and test for timezone drop in GroupBy.shift/bfill/ffill #27992
Timezone info is dropped in GroupBy.shift, bfill, and ffill
Could you please find and review this fix?
1.0.0, unless this is a regression in 0.25.x.…
On Fri, Aug 23, 2019 at 8:52 AM William Ayd ***@***.***> wrote: *@WillAyd* requested changes on this pull request. ------------------------------ In pandas/core/groupby/groupby.py <#27992 (comment)>: > @@ -2220,26 +2220,28 @@ def _get_cythonized_result( base_func = getattr(libgroupby, how) for name, obj in self._iterate_slices(): + values = obj._data._values Hmm I'm not sure relying on underlying block values is the best way to go about this. Is it possible to just work with the obj here instead? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#27992?email_source=notifications&email_token=AAKAOITRKMZJLG3H2KELYODQF7TQNA5CNFSM4IMSLLYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCQWFKQ#pullrequestreview-279012010>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIXQRK4RRN4LSTZ5RR3QF7TQNANCNFSM4IMSLLYA> .
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones.
Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!
If these instruction are inaccurate, feel free to suggest an improvement.