Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix groupby quantile array #28113

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 23, 2019

xref #28085 (comment)

This is a regression in 0.25.2. It was partially fixed in #28085, but there was an issue with the first fix.

@jbrockmendel

This comment has been minimized.

Copy link
Member

jbrockmendel commented Aug 23, 2019

LGTM

@dragoljub

This comment has been minimized.

Copy link

dragoljub commented Aug 23, 2019

@TomAugspurger thanks for the quick fix and adding the test! 👍

@TomAugspurger

This comment has been minimized.

Copy link
Contributor Author

TomAugspurger commented Aug 26, 2019

@WillAyd care to glance at this?

Note that this whole section is a bit hacky, but can be removed entirely once #10710 is fixed.

@WillAyd

This comment has been minimized.

Copy link
Member

WillAyd commented Aug 26, 2019

lgtm - can you add a whatsnew?

@TomAugspurger

This comment has been minimized.

Copy link
Contributor Author

TomAugspurger commented Aug 26, 2019

Whoops, added.

Copy link
Member

WillAyd left a comment

merge on green

@WillAyd WillAyd merged commit 294a22c into pandas-dev:master Aug 26, 2019
13 checks passed
13 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190826.19 succeeded
Details
pandas-dev.pandas (Checks) Checks succeeded
Details
pandas-dev.pandas (Docs) Docs succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_32bit) Linux py36_32bit succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 26, 2019
WillAyd added a commit that referenced this pull request Aug 27, 2019
gabriellm1 added a commit to gabriellm1/pandas that referenced this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.