Skip to content

Conversation

@gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 5, 2019

Closes #21411

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Groupby labels Nov 5, 2019
@gfyoung gfyoung added this to the 1.0 milestone Nov 5, 2019
@jbrockmendel jbrockmendel added Needs Tests Unit test(s) needed to prevent regressions and removed Needs Tests Unit test(s) needed to prevent regressions labels Nov 5, 2019
@gfyoung gfyoung force-pushed the test-nlargest-mi-grouper branch from e3661c7 to ccb778b Compare November 5, 2019 23:58
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit c918f7e into pandas-dev:master Nov 6, 2019
@jreback
Copy link
Contributor

jreback commented Nov 6, 2019

thanks @gfyoung

@gfyoung gfyoung deleted the test-nlargest-mi-grouper branch November 6, 2019 19:28
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Groupby Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nlargest of multiindex grouper throw type error: nlargest() got an unexpected keyword argument 'axis'

3 participants