Skip to content

/pandas

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert bins to numeric for histogram if a string #29639

Open
wants to merge 2 commits into
base: master
from
Open

Convert bins to numeric for histogram if a string #29639

wants to merge 2 commits into from
+13 −0

Conversation

@wesbarnett
Copy link

wesbarnett commented Nov 15, 2019 •
edited

Fixes #29484

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@wesbarnett
Convert bins to numeric for histogram if a string
Loading status checks…
5a240ab 
Fixes #29484
@WillAyd
WillAyd requested changes Nov 17, 2019
View changes
Copy link
Member

WillAyd left a comment

Can you add test(s)? We typically look for these as the first part of any PR
@wesbarnett

This comment has been minimized.

Sign in to view
Copy link
Author

wesbarnett commented Nov 20, 2019

Yes I'll work on creating a test.
@wesbarnett
Add unit test
Loading status checks…
7e1733b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd

Assignees
No one assigned
Labels
Visualization
Projects
None yet
Milestone
No milestone
2 participants
@wesbarnett @WillAyd
You can’t perform that action at this time.