Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert bins to numeric for histogram if a string #29639

Open
wants to merge 2 commits into
base: master
from

Conversation

@wesbarnett
Copy link

wesbarnett commented Nov 15, 2019

Fixes #29484

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
Copy link
Member

WillAyd left a comment

Can you add test(s)? We typically look for these as the first part of any PR

@wesbarnett

This comment has been minimized.

Copy link
Author

wesbarnett commented Nov 20, 2019

Yes I'll work on creating a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.