Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced !r with repr() #30020

Merged
merged 2 commits into from Dec 11, 2019
Merged

Replaced !r with repr() #30020

merged 2 commits into from Dec 11, 2019

Conversation

@kvn219
Copy link
Contributor

kvn219 commented Dec 3, 2019

  • reference #29886
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Issue: #29886

@WillAyd

@kvn219 kvn219 changed the title Replaced 'rm -rf pandas-kvn219' with repr() Replaced !r with repr() Dec 3, 2019
@WillAyd

This comment has been minimized.

Copy link
Member

WillAyd commented Dec 4, 2019

Thanks for the PR. Looks good and I think CI failures are unrelated / have been fixed on master since this was created.

To be sure, can you locally on your fstring-sorting branch run:

git fetch upstream
git merge upstream/master
git push origin fstring-sorting

I think should get CI green for this. Flag me down at PyData if you have any questions

Copy link
Member

simonjayhawkins left a comment

@kvn219 lgtm pending green ci

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 4, 2019
@@ -264,7 +264,7 @@ def nargsort(items, kind="quicksort", ascending: bool = True, na_position="last"
elif na_position == "first":
indexer = np.concatenate([nan_idx, indexer])
else:
raise ValueError("invalid na_position: {!r}".format(na_position))
raise ValueError(f"invalid na_position: {repr(na_position)}")

This comment has been minimized.

Copy link
@jreback

jreback Dec 4, 2019

Contributor

you can remove the repr on both of these as its unecessary

This comment has been minimized.

Copy link
@kvn219

kvn219 Dec 11, 2019

Author Contributor

Thanks for the feedback @jreback, I just pushed with repr() removed.

@WillAyd

This comment has been minimized.

Copy link
Member

WillAyd commented Dec 9, 2019

Looks like a merge conflict @kvn219 can you fix that up and re-push?

knguyen knguyen
@kvn219

This comment has been minimized.

Copy link
Contributor Author

kvn219 commented Dec 11, 2019

Looks like a merge conflict @kvn219 can you fix that up and re-push?

@kvn219 kvn219 closed this Dec 11, 2019
@kvn219

This comment has been minimized.

Copy link
Contributor Author

kvn219 commented Dec 11, 2019

Hey @WillAyd, I'm not sure what to do. I'll go to HackLA next week and ask for help.

@kvn219 kvn219 reopened this Dec 11, 2019
@simonjayhawkins simonjayhawkins merged commit db60c79 into pandas-dev:master Dec 11, 2019
13 checks passed
13 checks passed
Checks Checks
Details
Checks Checks
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas #20191211.13 succeeded
Details
pandas-dev.pandas (Linux py36_32bit) Linux py36_32bit succeeded
Details
pandas-dev.pandas (Linux py36_locale) Linux py36_locale succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py36_minimum_versions) Linux py36_minimum_versions succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Web_and_Docs) Web_and_Docs succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py36_macos) macOS py36_macos succeeded
Details
@simonjayhawkins

This comment has been minimized.

Copy link
Member

simonjayhawkins commented Dec 11, 2019

Thanks @kvn219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.