Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned Up setup.py includes #30201

Merged
merged 6 commits into from Dec 12, 2019
Merged

Cleaned Up setup.py includes #30201

merged 6 commits into from Dec 12, 2019

Conversation

@WillAyd
Copy link
Member

WillAyd commented Dec 11, 2019

Looking to make these more explicit and remove where not required

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Dec 11, 2019

Hello @WillAyd! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-12 18:28:45 UTC
@jreback jreback added the Clean label Dec 11, 2019
@jreback jreback added this to the 1.0 milestone Dec 11, 2019
@jreback

This comment has been minimized.

Copy link
Contributor

jreback commented Dec 11, 2019

should rebase this after we merge #30112

@jbrockmendel

This comment has been minimized.

Copy link
Member

jbrockmendel commented Dec 11, 2019

LGTM

@jbrockmendel

This comment has been minimized.

Copy link
Member

jbrockmendel commented Dec 12, 2019

needs rebase

@WillAyd WillAyd merged commit 1a1aebb into pandas-dev:master Dec 12, 2019
11 checks passed
11 checks passed
Checks Checks
Details
pandas-dev.pandas #20191212.61 succeeded
Details
pandas-dev.pandas (Linux py36_32bit) Linux py36_32bit succeeded
Details
pandas-dev.pandas (Linux py36_locale) Linux py36_locale succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py36_minimum_versions) Linux py36_minimum_versions succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Web_and_Docs) Web_and_Docs succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py36_macos) macOS py36_macos succeeded
Details
@WillAyd WillAyd deleted the WillAyd:simplified-setup branch Dec 12, 2019
EydenVillanueva added a commit to EydenVillanueva/pandas that referenced this pull request Dec 13, 2019
proost added a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost added a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.