Skip to content

BUG: DTI/TDI.insert doing invalid casting #33703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2020
Merged

BUG: DTI/TDI.insert doing invalid casting #33703

merged 5 commits into from
Apr 25, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 21, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

simonjayhawkins
simonjayhawkins reviewed Apr 21, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this closes any issues?

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Apr 21, 2020

does this closes any issues?

Not AFAICT

@jbrockmendel jbrockmendel added the Index Related to the Index class or subclasses label Apr 21, 2020
@jreback jreback added this to the 1.1 milestone Apr 25, 2020
@jreback
Copy link
Contributor

jreback commented Apr 25, 2020

looks good, can you merge master and ping on green.

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Apr 25, 2020

rebased+green

@jreback jreback merged commit afb0464 into pandas-dev:master Apr 25, 2020
@jbrockmendel jbrockmendel deleted the bug-dti-insert branch April 26, 2020 00:32
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@jbrockmendel @rhshadrach
BUG: DTI/TDI.insert doing invalid casting (pandas-dev#33703)
dbdf81a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

Assignees

No one assigned

Labels

Bug Index Related to the Index class or subclasses

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @jreback @simonjayhawkins