REF/CLN: Parametrize _isna #33835
Merged
REF/CLN: Parametrize _isna #33835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. _isna_ndarraylike should get a similar treatment; IIRC there is an issue with EAs not handling |
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
Thanks @dsaxton generally lgtm
pandas/core/dtypes/missing.py
Outdated
|
|
||
|
|
||
| def _isna_old(obj): | ||
| def _isna(obj, old: bool = False): |
Member
There was a problem hiding this comment.
would it make sense to use, say, inf_as_na = True/False moving forward and remove the old concept for clarity. (follow-on ok too)
also could maybe use lib.no_default and look up options if not passed instead of the using the callback and partial.
Contributor
There was a problem hiding this comment.
i agree this makes it more clear what is going on
jreback
requested changes
Apr 28, 2020
pandas/core/dtypes/missing.py
Outdated
|
|
||
|
|
||
| def _isna_old(obj): | ||
| def _isna(obj, old: bool = False): |
Contributor
There was a problem hiding this comment.
i agree this makes it more clear what is going on
jorisvandenbossche
approved these changes
Apr 29, 2020
Member
|
Thanks! |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 29, 2020
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces two nearly identical isna functions with one by parametrizing over the difference