Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: allow to_html and to_latex to take a path for their first argument #3702

Merged
merged 1 commit into from May 30, 2013

Conversation

@cpcloud
Copy link
Member

commented May 28, 2013

No description provided.

@jreback

This comment has been minimized.

Copy link
Contributor

commented May 28, 2013

not so sure that to_string should take this argument; its for a pure string rep, while to_csv has all the options for outputing to a file (eg. specialized nan rep, separators, etc)

@y-p ?

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented May 28, 2013

Yeah that's right. More things to maintain for u guys and probably would be confusing for new users. Will take out

@ghost

This comment has been minimized.

Copy link

commented May 28, 2013

Agree with jeff, doesn't belong in to_string.

I would opt for isinstance(basestring) here, 'better to ask forgiveness" not withstanding.
to_html(FooObject) should not try to open(FooObject), it should give a sane error message.

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented May 28, 2013

@y-p indeed, thanks.

jreback added a commit that referenced this pull request May 30, 2013
Merge pull request #3702 from cpcloud/read-and-friends-path-or-buf
ENH: allow to_html and to_latex to take a path for their first argument

@jreback jreback merged commit 6c7e32b into pandas-dev:master May 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.