Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
FIX/ENH: attempt soft conversion of object series before raising a TypeError when plotting #3912
Conversation
cpcloud
was assigned
Jun 15, 2013
|
this leads the user to believe that @wesm ? |
|
oh I see ok maybe do the conversion if needed (and warn if u can do the conversion but let it proceed - PerformanceWarning) |
|
ok i'll add the perf warning. |
|
@jreback ok 2 merge? |
jreback
and 1 other
commented on an outdated diff
Jun 15, 2013
| @@ -198,6 +198,15 @@ def test_all_invalid_plot_data(self): | ||
| self.assertRaises(TypeError, s.plot, kind=kind) | ||
| @slow | ||
| + def test_valid_object_plot(self): | ||
| + from pandas.io.pytables import PerformanceWarning | ||
| + s = Series(range(10), dtype=object) |
jreback
Contributor
|
|
@jreback any objections? going 2 merge if not... |
|
No please do not put in a performance warning! Thank you for fixing this though |
|
sure thing. hope i didn't ruffle too many feathers. trying to avoid |
|
@wesm merge-able? |
|
@jreback merge? anyone, beuller? trying to assist in as many 0.11.1 issues as i can... |
|
ok then |
cpcloud
added a commit
that referenced
this pull request
Jun 16, 2013
|
|
cpcloud |
b3f16da
|
cpcloud commentedJun 15, 2013
No description provided.