Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/BUG: fix failing data.py tests for good #4054

Merged
merged 1 commit into from Jun 28, 2013

Conversation

@cpcloud
Copy link
Member

commented Jun 27, 2013

closes #4028, #3982. for good.

@ghost ghost assigned cpcloud Jun 27, 2013

@wesm

This comment has been minimized.

Copy link
Member

commented Jun 27, 2013

👍

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2013

thanks. i'm going to do a couple more rehashes + push to make sure nothing is falling through the cracks. 4-5 seems to be the magic number to get at least one fail in the build matrix. i think i've done 2 so far

@woodb

This comment has been minimized.

Copy link

commented Jun 27, 2013

Could you cc me when you merge this one?

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2013

@woodb sure thing

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2013

@jreback look ok? the last 4 git rehashes and force pushes have passed on travis. running another one just in case. when that succeeds i wiil merge

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2013

ok by me

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2013

bombs away................

cpcloud added a commit that referenced this pull request Jun 28, 2013
Merge pull request #4054 from cpcloud/fix-failing-data-py-tests
TST/BUG: fix failing data.py tests for good

@cpcloud cpcloud merged commit 1a67a8f into pandas-dev:master Jun 28, 2013

@cpcloud cpcloud deleted the cpcloud:fix-failing-data-py-tests branch Jun 28, 2013

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2013

cc @woodb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.