/pandas

TST/BUG: fix 2to3 import rewrite of import pickle #4063

Merged
merged 2 commits into from Jun 28, 2013

Conversation

Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
None yet
Projects
None yet
Milestone
  0.12
3 participants
@cpcloud @jreback @y-p
@cpcloud
Member

cpcloud commented Jun 27, 2013

In pandas.io.pickle the following statement will not allow python to import
anything due to the following rewrite by 2to3

import pickle -> from . import pickle

This makes the import try to import itself ad infinitum and thus fails.

closes #4062

cpcloud was assigned Jun 27, 2013

@cpcloud
Member

cpcloud commented Jun 28, 2013

@jreback even though i said 0.13 for this one i'd like to get this in for 0.12 would be nice to be able to run tox on py3.x...
@jreback
Contributor

jreback commented Jun 28, 2013

ok by me
@cpcloud
Member

cpcloud commented Jun 28, 2013

btw i tried w/ numpy 1.5.1 and works fine

cpcloud added some commits Jun 27, 2013

@cpcloud cpcloud TST/BUG: fix 2to3 import rewrite of import pickle 
In pandas.io.pickle the following statement will not allow python to import
anything due to the following rewrite by 2to3

import pickle -> from . import pickle

This make the import try to import itself ad infinitum and thus fails.
 5b0d78b
@cpcloud cpcloud TST: make tox block when running in parallel 858da94

@cpcloud cpcloud added a commit that referenced this pull request Jun 28, 2013

@cpcloud cpcloud Merge pull request #4063 from cpcloud/tox-pkl-import-fix 
TST/BUG: fix 2to3 import rewrite of import pickle
 f418a0e

@cpcloud cpcloud merged commit f418a0e into pandas-dev:master Jun 28, 2013

cpcloud deleted the cpcloud:tox-pkl-import-fix branch Jun 28, 2013

@y-p
Contributor

y-p commented Jun 29, 2013

I think it's time to ditch tox_prll.sh and move to detox,
tox_prll was a hack from a time when detox was having growing pains.
@cpcloud
Member

cpcloud commented Jun 29, 2013

is this a dropin replacement?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment