Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix data.py regression #4281

Merged
merged 1 commit into from Jul 18, 2013

Conversation

@cpcloud
Copy link
Member

commented Jul 18, 2013

get_data_famafrench was not returning any data because of an incorrect slice
and read + splitlines != readlines for zipfiles

@ghost ghost assigned cpcloud Jul 18, 2013

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2013

@jreback look ok?

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2013

this bug was actually caught by a doc build

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2013

interesting...guess it could be worth it to add in doc builds to travis?

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2013

Yep the docs function nicely as smoke tests.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2013

loook ok to me

cpcloud added a commit that referenced this pull request Jul 18, 2013

@cpcloud cpcloud merged commit b7dfe9f into pandas-dev:master Jul 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.