/pandas

BUG: fix data.py regression #4281

Merged
merged 1 commit into from Jul 18, 2013

Conversation

Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
None yet
Projects
None yet
Milestone
  0.12
3 participants
@cpcloud @jtratner @jreback
@cpcloud
Member

cpcloud commented Jul 18, 2013

get_data_famafrench was not returning any data because of an incorrect slice
and read + splitlines != readlines for zipfiles

cpcloud was assigned Jul 18, 2013

@cpcloud
Member

cpcloud commented Jul 18, 2013

@jreback look ok?
@cpcloud
Member

cpcloud commented Jul 18, 2013

this bug was actually caught by a doc build
@jtratner
Contributor

jtratner commented Jul 18, 2013

interesting...guess it could be worth it to add in doc builds to travis?
@cpcloud
Member

cpcloud commented Jul 18, 2013

Yep the docs function nicely as smoke tests.
@jreback
Contributor

jreback commented Jul 18, 2013

loook ok to me

@cpcloud cpcloud added a commit that referenced this pull request Jul 18, 2013

@cpcloud cpcloud Merge pull request #4281 from cpcloud/data-py-regression-fix 
BUG: fix data.py regression
 b7dfe9f

@cpcloud cpcloud merged commit b7dfe9f into pandas-dev:master Jul 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment