Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: let URLError fall through in pandas.io.html._read #4305

Merged
merged 1 commit into from Jul 25, 2013

Conversation

@cpcloud
Copy link
Member

commented Jul 20, 2013

No description provided.

@ghost ghost assigned cpcloud Jul 20, 2013

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2013

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2013

@cpcloud handling network IO is clearly tricky. Were you able to recreate the conditions for the error that was initially raised with the original URL?

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2013

nope. just skipping for now if raising IOError (this is what the network decorator does), but there's something going on with a bogus url that i'm passing in tests with unicode not sure what yet

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2013

marking for 0.13 because i'm not sure if i'll be able to get this by this weekend

CLN: remove try suite in _read
A skip will now occur if a call to urlopen or a read from the resulting object
throws a urllib2.URLError exception
cpcloud added a commit that referenced this pull request Jul 25, 2013
Merge pull request #4305 from cpcloud/add-urlerror-info
CLN: let URLError fall through in pandas.io.html._read

@cpcloud cpcloud merged commit c722914 into pandas-dev:master Jul 25, 2013

@cpcloud cpcloud deleted the cpcloud:add-urlerror-info branch Jul 25, 2013

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2013

oh phooey i put in 0.12 release notes 😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.