Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: GH4409 HDFStore adds an is_open property / CLOSED message #4417

Merged
merged 1 commit into from Aug 2, 2013

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jul 31, 2013

closes #4409
closes #4367

@michaelaye
Copy link
Contributor

Just out of curiosity: What's the reason for writing GH4409 in the title instead of # 4409? To avoid too many links? I have seen it several times now. Is it a 'style' agreement?

@cpcloud
Copy link
Member

cpcloud commented Aug 1, 2013

i think it's just convention

…erlying file handle is_open;

    a closed store will now report 'CLOSED' when viewing the store (rather than raising an error)

API: HDFStore, removed the _quiet attribute, replace by a ``DuplicateWarning`` if retrieving
     duplicate rows from a table (GH4367)

TST: change warnings filter to assert_produces_warning in test_pytables.py

API: removed the warn argument from open. Instead a PossibleDataLoss exception will
     be raised if you try use mode='w' with an OPEN file handle (GH4367)

API: semantics of close in HDFStore now will close that instance of HDFStore
     the final file close is ref counted (by PyTables) w.r.t all of the open handles

ENH: raise ClosedFileError if an operation is attempted on a closed file
jreback added a commit that referenced this pull request Aug 2, 2013
API: GH4409 HDFStore adds an is_open property / CLOSED message
@jreback jreback merged commit 5544b89 into pandas-dev:master Aug 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: HDFStore closing is buggy ER: In HDFStore create warnings for mode, quiet
3 participants