Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: allow cumprod and cumsum to work with bool dtypes #4440

Merged
merged 1 commit into from Aug 7, 2013

Conversation

@cpcloud
Copy link
Member

commented Aug 2, 2013

closes #4170.

@ghost ghost assigned cpcloud Aug 2, 2013

@hayd

View changes

pandas/tests/test_series.py Outdated
'cummin': cummin, 'cummax': cummax}
args = product((a, b, c, d), methods)
for s, method in args:
expected = Series(methods[method](b.values))

This comment has been minimized.

Copy link
@hayd

hayd Aug 2, 2013

Contributor

should this be s (rather than b)?

This comment has been minimized.

Copy link
@cpcloud

cpcloud Aug 2, 2013

Author Member

doh thanks!

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2013

@jreback this ok 2 merge?

@jreback

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2013

release notes?

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2013

whoops thanks

hayd added a commit that referenced this pull request Aug 7, 2013
Merge pull request #4440 from cpcloud/fix-cumsum-bool
BUG: allow cumprod and cumsum to work with bool dtypes

@hayd hayd merged commit 3841ae6 into pandas-dev:master Aug 7, 2013

@hayd

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2013

boom!

Awesome, will make a new issue for inserting nans into int/bool Series (if there isn't already), a la #4170.

@cpcloud cpcloud deleted the cpcloud:fix-cumsum-bool branch Aug 7, 2013

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2013

thanks @hayd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.