Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: isinstance(x, int) -> is_integer(x) #46119

Merged
merged 1 commit into from Feb 26, 2022

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Feb 22, 2022

No description provided.

Copy link
Member

@mroeschke mroeschke left a comment

Nice LGTM

@mroeschke mroeschke added the Refactor Internal refactoring of code label Feb 22, 2022
@mroeschke mroeschke added this to the 1.5 milestone Feb 22, 2022
@jbrockmendel
Copy link
Member

jbrockmendel commented Feb 23, 2022

Is there user-facing in a way that could represent a bugfix?

@attack68
Copy link
Contributor Author

attack68 commented Feb 23, 2022

Is there user-facing in a way that could represent a bugfix?

I can't remember why this came up, but there was a reason. It might have been when formatting new Int64 with thousands separator, but the Int64 didn't get detected by int so didn't show the separator. This fix was recommended to me in another PR recently.

@jreback
Copy link
Contributor

jreback commented Feb 26, 2022

you could actually test this (e.g. pass in np.int64 intead of ints for some args), but nbd.

@jreback jreback merged commit 541bbf9 into pandas-dev:main Feb 26, 2022
45 checks passed
@attack68 attack68 deleted the styler_is_xx branch Mar 6, 2022
simonjayhawkins added a commit that referenced this pull request Mar 25, 2022
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Mar 25, 2022

@meeseeksdev backport 1.4.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 25, 2022
simonjayhawkins added a commit that referenced this pull request Mar 29, 2022
Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants