Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #46119 on branch 1.4.x (REF: isinstance(x, int) -> is_integer(x)) #46501

Conversation

meeseeksmachine
Copy link

@meeseeksmachine meeseeksmachine commented Mar 25, 2022

Backport PR #46119: REF: isinstance(x, int) -> is_integer(x)

@meeseeksdev meeseeksdev bot added this to the 1.5 milestone Mar 25, 2022
@meeseeksdev meeseeksdev bot added the Refactor Internal refactoring of code label Mar 25, 2022
@simonjayhawkins simonjayhawkins marked this pull request as draft Mar 25, 2022
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Mar 25, 2022

Alternative to #46500, is to backport and follow-up with a test and release note.

As this is not atomic, personally I prefer the revert and redo option.

@simonjayhawkins simonjayhawkins modified the milestones: 1.5, 1.4.2 Mar 25, 2022
@simonjayhawkins simonjayhawkins added Regression Functionality that used to work in a prior pandas version Styler conditional formatting using DataFrame.style and removed Refactor Internal refactoring of code labels Mar 25, 2022
@attack68
Copy link
Contributor

attack68 commented Mar 28, 2022

I think either might work, i probably prefer just the add tests and whats new option personally due to simplicity.

@jreback
Copy link
Contributor

jreback commented Mar 28, 2022

I think this PR is fine

@simonjayhawkins simonjayhawkins marked this pull request as ready for review Mar 29, 2022
@simonjayhawkins simonjayhawkins merged commit ccdb97e into pandas-dev:1.4.x Mar 29, 2022
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Functionality that used to work in a prior pandas version Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants