BUG: Series.map is ignoring the na_action keyword #46860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 24, 2022
mroeschke
requested changes
Apr 24, 2022
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Also good to have a whatsnew entry in 1.5.0.rst (probably in the Other Enhancement section as a improvement in error reporting)
|
Hello @stanleycai95! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-04-26 01:48:01 UTC |
Contributor
Author
|
Added documentation updates + test. Thank you for the feedback!! |
stanleycai95
changed the title
mroeschke
reviewed
Apr 25, 2022
rhshadrach
added
Bug
Missing-data
jreback
requested changes
Apr 26, 2022
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
minor comment, pls merge master and ping on green
stanleycai95
commented
Apr 26, 2022
mroeschke
approved these changes
Apr 26, 2022
jreback
approved these changes
Apr 27, 2022
Contributor
|
thanks @stanleycai95 very nice! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series.mapis ignoring thena_actionkeyword #46588