Skip to content

Conversation

@wf-r
Copy link
Contributor

@wf-r wf-r commented May 25, 2022

@pep8speaks
Copy link

pep8speaks commented May 25, 2022

Hello @wf-r! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-15 05:14:21 UTC

@wf-r
Copy link
Contributor Author

wf-r commented May 25, 2022

@github-actions pre-commit

@wf-r
Copy link
Contributor Author

wf-r commented Jun 14, 2022

@github-actions pre-commit

@wf-r wf-r requested a review from phofl June 14, 2022 08:49
@wf-r
Copy link
Contributor Author

wf-r commented Jun 14, 2022

@phofl Thanks for your feedback, I think you can take another look.

@mroeschke mroeschke added IO Excel read_excel, to_excel MultiIndex labels Jun 15, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 15, 2022
@mroeschke mroeschke merged commit 9c241fe into pandas-dev:main Jun 15, 2022
@mroeschke
Copy link
Member

Thanks @wf-r

@wf-r wf-r deleted the empty_MI_to_excel branch June 17, 2022 04:08
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
…andas-dev#47111)

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

fix tests, and add changes

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

fix tests one more time

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

make PEP8 happy

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

make PEP8 happy

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

fix tests one last time

* Fixes from pre-commit [automated commit]

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

requested changes

* Fixes from pre-commit [automated commit]

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

remove comments

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

re-add gh ref

* BUG Avoid IndexError on writing empty (row) MI df to excel (GH19543)

fix changelog entry

Co-authored-by: wfr <git@wfriedl.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO Excel read_excel, to_excel MultiIndex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: to_excel to throw IndexError for dataframe with empty (row) MultiIndex

4 participants