Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: pd.array raising with NumPy array and large dtype #52591

Merged
merged 7 commits into from
Apr 27, 2023
Merged

BUG: pd.array raising with NumPy array and large dtype #52591

merged 7 commits into from
Apr 27, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Apr 11, 2023

not sure if we want to backport this though...

mroeschke
mroeschke reviewed Apr 11, 2023
View reviewed changes
pandas/core/arrays/arrow/array.py
pa.types.is_large_binary(pa_dtype) or pa.types.is_large_string(pa_dtype)
)
):
scalars = scalars.tolist()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open an issue in arrow and link that issue here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mroeschke mroeschke added Strings String extension data type and string data Arrow pyarrow functionality labels Apr 11, 2023
@phofl
Copy link
Member Author

phofl commented Apr 25, 2023

This should be ready

@mroeschke mroeschke added this to the 2.0.2 milestone Apr 27, 2023
@mroeschke mroeschke merged commit 3790452 into pandas-dev:main Apr 27, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@meeseeksmachine meeseeksmachine mentioned this pull request Apr 27, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 27, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#52591: BUG: pd.array raising with NumPy array …
15b186a 
…and large dtype
mroeschke pushed a commit that referenced this pull request Apr 27, 2023
@meeseeksmachine @phofl
Backport PR #52591 on branch 2.0.x (BUG: pd.array raising with NumPy …
91757c5 
…array and large dtype) (#52951)

Backport PR #52591: BUG: pd.array raising with NumPy array and large dtype

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@phofl phofl deleted the 52590 branch April 27, 2023 07:50
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 27, 2023
@phofl @topper-123
BUG: pd.array raising with NumPy array and large dtype (pandas-dev#52591
f5fd33b 
)

* BUG: pd.array raising with NumPy array and large dtype

* Fix

* Add gh ref

* Move
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
@phofl @topper-123
BUG: pd.array raising with NumPy array and large dtype (pandas-dev#52591
95ff882 
)

* BUG: pd.array raising with NumPy array and large dtype

* Fix

* Add gh ref

* Move
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
@phofl
BUG: pd.array raising with NumPy array and large dtype (pandas-dev#52591
d493815 
)

* BUG: pd.array raising with NumPy array and large dtype

* Fix

* Add gh ref

* Move
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@phofl
BUG: pd.array raising with NumPy array and large dtype (pandas-dev#52591
0cf70eb 
)

* BUG: pd.array raising with NumPy array and large dtype

* Fix

* Add gh ref

* Move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

BUG: pd.array raising for large_string/large_binary with NumPy array
2 participants
@phofl @mroeschke