From ccb1c84e597914335cfe668b6b2f93c8db3d43ae Mon Sep 17 00:00:00 2001 From: KevsterAmp Date: Mon, 5 Aug 2024 12:26:18 +0800 Subject: [PATCH 1/6] change sort parameter of DataFrameGroupBy.value_counts --- pandas/core/groupby/generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/groupby/generic.py b/pandas/core/groupby/generic.py index c112d9b6a4b54..48ac67715ae40 100644 --- a/pandas/core/groupby/generic.py +++ b/pandas/core/groupby/generic.py @@ -746,7 +746,7 @@ def value_counts( normalize : bool, default False Return proportions rather than frequencies. sort : bool, default True - Sort by frequencies. + Sort by frequencies when True. Sort by DataFrame column values when False. ascending : bool, default False Sort in ascending order. bins : int or list of ints, optional From b77066f6cf6519ddd11f232d5693f947420c944b Mon Sep 17 00:00:00 2001 From: KevsterAmp Date: Mon, 5 Aug 2024 14:01:15 +0800 Subject: [PATCH 2/6] remove sort parameter doc change on SeriesGroupby.value_counts --- pandas/core/groupby/generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/groupby/generic.py b/pandas/core/groupby/generic.py index 48ac67715ae40..2fc7496ae3ff1 100644 --- a/pandas/core/groupby/generic.py +++ b/pandas/core/groupby/generic.py @@ -746,7 +746,7 @@ def value_counts( normalize : bool, default False Return proportions rather than frequencies. sort : bool, default True - Sort by frequencies when True. Sort by DataFrame column values when False. + Sort by frequencies when True. ascending : bool, default False Sort in ascending order. bins : int or list of ints, optional From 37fcea48c761f5f332da839617652d33edf8fcad Mon Sep 17 00:00:00 2001 From: KevsterAmp Date: Mon, 5 Aug 2024 14:01:48 +0800 Subject: [PATCH 3/6] modify sort parameter doc change in DataFrameGroupby.value_counts --- pandas/core/groupby/generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/groupby/generic.py b/pandas/core/groupby/generic.py index 2fc7496ae3ff1..62ebfc5d02d77 100644 --- a/pandas/core/groupby/generic.py +++ b/pandas/core/groupby/generic.py @@ -2303,7 +2303,7 @@ def value_counts( normalize : bool, default False Return proportions rather than frequencies. sort : bool, default True - Sort by frequencies. + Sort by frequencies when True. Sort by DataFrame column values when False. ascending : bool, default False Sort in ascending order. dropna : bool, default True From ea33198b0eaba5845975a10b1de2aedb2b793d88 Mon Sep 17 00:00:00 2001 From: KevsterAmp Date: Mon, 5 Aug 2024 14:02:55 +0800 Subject: [PATCH 4/6] revert sort parameter doc of SeriesGroupBy.value_counts --- pandas/core/groupby/generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/groupby/generic.py b/pandas/core/groupby/generic.py index 62ebfc5d02d77..d2595ea15c060 100644 --- a/pandas/core/groupby/generic.py +++ b/pandas/core/groupby/generic.py @@ -746,7 +746,7 @@ def value_counts( normalize : bool, default False Return proportions rather than frequencies. sort : bool, default True - Sort by frequencies when True. + Sort by frequencies. ascending : bool, default False Sort in ascending order. bins : int or list of ints, optional From 900f653f0c3b684d5bd12a582215c6f92103f6b1 Mon Sep 17 00:00:00 2001 From: KevsterAmp Date: Tue, 6 Aug 2024 08:01:55 +0800 Subject: [PATCH 5/6] improve sort parameter doc of SeriesGroupBy.value_counts --- pandas/core/groupby/generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/groupby/generic.py b/pandas/core/groupby/generic.py index d2595ea15c060..8d2ca0718d5ee 100644 --- a/pandas/core/groupby/generic.py +++ b/pandas/core/groupby/generic.py @@ -746,7 +746,7 @@ def value_counts( normalize : bool, default False Return proportions rather than frequencies. sort : bool, default True - Sort by frequencies. + Sort by frequencies when True. Sort by DataFrame column values when False. ascending : bool, default False Sort in ascending order. bins : int or list of ints, optional From 7d28d96320f1e451dd04f5911fc42493ffd84583 Mon Sep 17 00:00:00 2001 From: KevsterAmp Date: Sun, 11 Aug 2024 13:19:47 +0800 Subject: [PATCH 6/6] update SeriesGroupBy.value_counts sort doc --- pandas/core/groupby/generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/groupby/generic.py b/pandas/core/groupby/generic.py index 8d2ca0718d5ee..3d2575ec3ac96 100644 --- a/pandas/core/groupby/generic.py +++ b/pandas/core/groupby/generic.py @@ -746,7 +746,7 @@ def value_counts( normalize : bool, default False Return proportions rather than frequencies. sort : bool, default True - Sort by frequencies when True. Sort by DataFrame column values when False. + Sort by frequencies when True. Preserve the order of the data when False. ascending : bool, default False Sort in ascending order. bins : int or list of ints, optional