Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify API in regards to column-vs-columns #773

Closed
wants to merge 1 commit into from

Conversation

@yarikoptic
Copy link
Contributor

commented Feb 10, 2012

This is the "fix" only for 1 case out of few other possible:

$> git grep 'def.*column=' 
pandas/core/frame.py:    def boxplot(self, column=None, by=None, ax=None, fontsize=None,
pandas/stats/misc.py:def percentileRank(frame, column=None, kind='mean'):
pandas/tools/plotting.py:def boxplot(data, column=None, by=None, ax=None, fontsize=None,
ENH: API change -- sort (columns=) instead of column=
to be more adequate and correspond to provided docstring
@adamklein

This comment has been minimized.

Copy link

commented on e2bb42a Feb 13, 2012

Shouldn't directly replace "column", but rather add a new "columns" argument and add a deprecation warning for "column". Eg,

    if column is not None:  # pragma: no cover
        import warnings
        warnings.warn("column is deprecated, use columns", FutureWarning)

Thanks!

This comment has been minimized.

Copy link
Member Author

replied Feb 13, 2012

yeap--ideal solution indeed should be smth like that ;-) shouldn't it also assign it to columns if that one is None?

thanks also for pointing "pragma: no cover" -- didn't know about it before

@adamklein adamklein closed this in de6318e Feb 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.