Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG: fix reading pre-0.14.1 pickles of containers with one block and dup items #7794
Conversation
immerrr
changed the title from
Fix unpickling series with non unique index to BUG: fix reading pre-0.14.1 pickles of containers with one block and non-unique items
Jul 18, 2014
immerrr
changed the title from
BUG: fix reading pre-0.14.1 pickles of containers with one block and non-unique items to BUG: fix reading pre-0.14.1 pickles of containers with one block and dup items
Jul 18, 2014
|
just put up some legacy files whatever your python / platform (if u want to multiple versions of oython that's ok) it doesn't matter much that we have for every platform for very version cross compat is pretty much there |
|
Ok, I've added pickles for 0.13.0, 0.14.0 (just in case) and 0.14.1. |
jreback
added the
Compat
label
Jul 18, 2014
jreback
added this to the
0.15.0
milestone
Jul 18, 2014
|
perfect! ping when green |
|
you have to add the directory of 0.14.0 to (actually prob is a better way to do by adding all directories under data), any idea? |
|
@immerrr pls rebase another commit added the 0.14.0 pickle dir already |
|
rebased and green |
jreback
added a commit
that referenced
this pull request
Jul 21, 2014
|
|
jreback |
73598c1
|
jreback
merged commit 73598c1
into pandas-dev:master
Jul 21, 2014
1 check passed
|
@immerrr thanks for the fix! preserving pickle compat is never easy! |
immerrr commentedJul 18, 2014
Series, frames and panels that contain only one block can be unpickled
under the assumption that block items correspond to manager items 1-to-1
(as pointed out in #7329).
I still don't have any of darwin/win/32bit platforms at hand, so I
cannot post those pickles. Also, my linux has a fresher python than
indicated by filenames of existing pickle test data. I did generate
some data to test the fix, the question is do you want me to upload it?