BUG: fix reading pre-0.14.1 pickles of containers with one block and dup items #7794

Merged
merged 2 commits into from Jul 21, 2014

Conversation

Projects
None yet
2 participants
Contributor

immerrr commented Jul 18, 2014

Series, frames and panels that contain only one block can be unpickled
under the assumption that block items correspond to manager items 1-to-1
(as pointed out in #7329).

I still don't have any of darwin/win/32bit platforms at hand, so I
cannot post those pickles. Also, my linux has a fresher python than
indicated by filenames of existing pickle test data. I did generate
some data to test the fix, the question is do you want me to upload it?

immerrr changed the title from Fix unpickling series with non unique index to BUG: fix reading pre-0.14.1 pickles of containers with one block and non-unique items Jul 18, 2014

immerrr changed the title from BUG: fix reading pre-0.14.1 pickles of containers with one block and non-unique items to BUG: fix reading pre-0.14.1 pickles of containers with one block and dup items Jul 18, 2014

Contributor

jreback commented Jul 18, 2014

just put up some legacy files whatever your python / platform (if u want to multiple versions of oython that's ok)

it doesn't matter much that we have for every platform for very version

cross compat is pretty much there

Contributor

immerrr commented Jul 18, 2014

Ok, I've added pickles for 0.13.0, 0.14.0 (just in case) and 0.14.1.

jreback added the Compat label Jul 18, 2014

jreback added this to the 0.15.0 milestone Jul 18, 2014

Contributor

jreback commented Jul 18, 2014

perfect! ping when green

Contributor

jreback commented Jul 18, 2014

you have to add the directory of 0.14.0 to setup.py, see here: https://github.com/pydata/pandas/blob/master/setup.py#L578

(actually prob is a better way to do by adding all directories under data), any idea?

Contributor

jreback commented Jul 19, 2014

@immerrr pls rebase another commit added the 0.14.0 pickle dir already

immerrr added some commits Jul 18, 2014

@immerrr immerrr TST: add mixed-type panels & frames to generate_legacy_pickles
Don't generate them for pre-0.14.1 as they cannot be unpickled.
9eed2e4
@immerrr immerrr BUG: fix unpickling of some pre-0.14.1 pickles with non-unique items
Series, frames and panels that contain only one block can be unpickled
under the assumption that block items correspond to manager items 1-to-1.
4434f48
Contributor

immerrr commented Jul 20, 2014

rebased and green

@jreback jreback added a commit that referenced this pull request Jul 21, 2014

@jreback jreback Merge pull request #7794 from immerrr/fix-unpickling-series-with-non-…
…unique-index

BUG: fix reading pre-0.14.1 pickles of containers with one block and dup items
73598c1

@jreback jreback merged commit 73598c1 into pandas-dev:master Jul 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Contributor

jreback commented Jul 21, 2014

@immerrr thanks for the fix! preserving pickle compat is never easy!

immerrr deleted the immerrr:fix-unpickling-series-with-non-unique-index branch Jul 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment