Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #806 DataFrame/Series.align can now specify fill_value or fill_method #807

Merged
merged 8 commits into from Feb 23, 2012

Conversation

@changhiskhan
Copy link
Contributor

commented Feb 21, 2012

No description provided.

@wesm

This comment has been minimized.

Copy link
Member

commented Feb 23, 2012

you'll want to do work like this in a branch, see:

http://pandas.pydata.org/developers.html#working-with-the-code

After this gets merged you'll want to fetch upstream and do

git reset --hard upstream/master

so you get rid of those merge commits above. git takes some git-ing used to

@changhiskhan

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2012

Ahhh the reset step. Thanks! Will be up to speed soon :)
On Feb 23, 2012 2:08 PM, "Wes McKinney" <
reply@reply.github.com>
wrote:

you'll want to do work like this in a branch, see:

http://pandas.pydata.org/developers.html#working-with-the-code

After this gets merged you'll want to fetch upstream and do

git reset --hard upstream/master

so you get rid of those merge commits above. git takes some git-ing used to


Reply to this email directly or view it on GitHub:
#807 (comment)

@changhiskhan

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2012

Also, u get a slap in the back of the head for using a "git" pun :P
On Feb 23, 2012 2:08 PM, "Wes McKinney" <
reply@reply.github.com>
wrote:

you'll want to do work like this in a branch, see:

http://pandas.pydata.org/developers.html#working-with-the-code

After this gets merged you'll want to fetch upstream and do

git reset --hard upstream/master

so you get rid of those merge commits above. git takes some git-ing used to


Reply to this email directly or view it on GitHub:
#807 (comment)

wesm added a commit that referenced this pull request Feb 23, 2012
Merge pull request #807 from changhiskhan/master
Issue #806 DataFrame/Series.align can now specify fill_value or fill_method

@wesm wesm merged commit 4175bf4 into pandas-dev:master Feb 23, 2012

@wesm

This comment has been minimized.

Copy link
Member

commented Feb 23, 2012

the test suite didn't pass with these changes-- I patched things up and looking good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.