You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The port should not default to port 80 if not specified in a request. Instead it should default to the value obtained from window.location.port unless it is undefined in which case it should default to 80.
When issuing a request using a relative path that omits the scheme, host, and port. The library correctly obtains the host from window.location.host, but does not correctly obtain the port from window.location.port.
The text was updated successfully, but these errors were encountered:
BTW, I think I see a related bug looking at the current master - https://github.com/pandastrike/shred/blob/master/src/request.coffee#L86 is defaulting to window?.port, but I think that should be location?.port or window?.location?.port (equivalent, but the latter is more obvious if you're not thinking about a client-side context)
The port should not default to port 80 if not specified in a request. Instead it should default to the value obtained from window.location.port unless it is undefined in which case it should default to 80.
This snippet:
Conflicts with this snippet:
When issuing a request using a relative path that omits the scheme, host, and port. The library correctly obtains the host from window.location.host, but does not correctly obtain the port from window.location.port.
The text was updated successfully, but these errors were encountered: