New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken Timers #154

Closed
WebReflection opened this Issue Jul 30, 2015 · 2 comments

Comments

2 participants
@WebReflection
Copy link

WebReflection commented Jul 30, 2015

By specification, and since about ever in every engine, timers accept extra arguments.

setTimeout(function (str) {
  console.log(str);
}, 1000, "Hello IoT.js!!");

Above code should log Hello IoT.js! ... it prints

uncaughtException: undefined

instead.

Please get core functionalities right ;-) thank you!

@ILyoan

This comment has been minimized.

Copy link
Contributor

ILyoan commented Jul 31, 2015

@WebReflection Thanks for pointing out. It looks like we haven't been visiting timer for long time since initial implementation. I'll take a look at this.

@ILyoan ILyoan added bug API labels Jul 31, 2015

@ILyoan ILyoan self-assigned this Jul 31, 2015

ILyoan added a commit to ILyoan/iotjs that referenced this issue Jul 31, 2015

Make timer handler take arguments. For pando-project#154.
IoT.js-DCO-1.0-Signed-off-by: Ilyong Cho ily.cho@samsung.com
@ILyoan

This comment has been minimized.

Copy link
Contributor

ILyoan commented Aug 3, 2015

Closing as #157 landed.
Feel free to reopen if needed

@ILyoan ILyoan closed this Aug 3, 2015

pmarcinkiew referenced this issue in pmarcinkiew/iotjs Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment