Fix the measure_coverage.sh script #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please also remove it from other places (e.g. Build-Script.md) ? Otherwise, LGTM (informally) |
|
@robertsipka Nice catch! Of course :) |
IoT.js-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
rtakacs
force-pushed
the
fix-measure-coverage
branch
from
3d427e5
to
fd17202
Compare
|
@robertsipka I've updated the files to have the new |
glistening
reviewed
Jan 11, 2018
| @@ -235,6 +227,14 @@ To build for nuttx os, nuttx home directory must be given. | |||
| ./tools/build.py --target-os=nuttx --target-arch=arm --target-board=stm32f4dis --nuttx-home="..." | |||
| ``` | |||
|
|
|||
| -- | |||
| #### `--run-test` | |||
| With given this option, unit test checking will be performed. | |||
There was a problem hiding this comment.
@rtakacs Although it is not a part of this PR, what about "run unit tests after build"? I would remove all occurrences of With given this option in explanation for each option. Without this phrases, it is still clear the each sentence explains the given option.
glistening
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the old
--no-check-testoption from the build flags.