Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use union to convert between jerryx_arg_int_option_t and uintptr_t #2718

Merged
merged 1 commit into from Jan 21, 2019
Merged

Use union to convert between jerryx_arg_int_option_t and uintptr_t #2718

merged 1 commit into from Jan 21, 2019

Conversation

akosthekiss
Copy link
Member

This fixes potential out-of-bounds reads in jerry-ext when dealing
with integer argument mappings.

Fixes #2713

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

@akosthekiss
Use union to convert between jerryx_arg_int_option_t and uintptr_t
5e1a68a 
This fixes potential out-of-bounds reads in jerry-ext when dealing
with integer argument mappings.

Fixes jerryscript-project#2713

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
@akosthekiss akosthekiss added bug Undesired behaviour jerry-ext Related to the jerry-ext library labels Jan 18, 2019
LaszloLango
LaszloLango approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rerobika
rerobika approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

robertsipka
robertsipka approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka robertsipka merged commit 67ef396 into jerryscript-project:master Jan 21, 2019
@akosthekiss akosthekiss deleted the fix-ext-arg-int-opt-info-conv branch January 21, 2019 08:55
@zherczeg zherczeg mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsipka robertsipka robertsipka approved these changes

@LaszloLango LaszloLango LaszloLango approved these changes

@rerobika rerobika rerobika approved these changes

Assignees
No one assigned
Labels
bug Undesired behaviour jerry-ext Related to the jerry-ext library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jerryscript-ext/arg.impl.h@106 has an out-of-bounds read
4 participants
@akosthekiss @robertsipka @LaszloLango @rerobika