Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawers:controller fails to use empty drawers #552

Open
SwissalpS opened this issue Oct 8, 2020 · 6 comments
Open

drawers:controller fails to use empty drawers #552

SwissalpS opened this issue Oct 8, 2020 · 6 comments
Assignees
Labels
bug 🐛 Something isn't working Waiting ⏳ Waiting for a fix, upstream issue, or a PR to be merged

Comments

@SwissalpS
Copy link
Contributor

  1. Set up a couple drawers and attach a controller
  2. attach tp-tube to controller for receiving
  3. send a stack
  4. controller correctly puts stack in an empty drawer
  5. send more stacks until drawer is full
  6. send one more stack
  7. Error: controller rejects stack even though there are empty drawers available.

Is this bug or feature?

@OgelGames
Copy link
Contributor

If I understand correctly, the drawer controller doesn't use empty drawers for overflow of full drawers? IMO this should be configurable on the drawer controller if that is the case.

@SwissalpS
Copy link
Contributor Author

Yes, I think you understood.
Also a config option would be cool.

@S-S-X
Copy link
Member

S-S-X commented Oct 10, 2020

I'd say it is kind of good feature in some cases to skip empty but very useful in others to allow filling empty so 👍 for config option, also default behavior for drawers in world should stay how it is currently: empty drawers skipped.
For newly added drawers / controllers default could be either way, just to keep behavior of already placed drawers.

@SwissalpS
Copy link
Contributor Author

SwissalpS commented Oct 14, 2020

I started to work on this branch.

@SwissalpS SwissalpS self-assigned this Oct 14, 2020
@SwissalpS
Copy link
Contributor Author

SwissalpS commented Oct 14, 2020

How should I label the toggle?
For now I have "Use all drawers". I think there is a better and more illuminating way of saying what it does.
Help appreciated.

@SwissalpS
Copy link
Contributor Author

@jessicara and others, please test / review this PR

@OgelGames OgelGames added Fixed Issue has been fixed/resolved but is waiting for something or needs testing Waiting ⏳ Waiting for a fix, upstream issue, or a PR to be merged bug 🐛 Something isn't working labels Oct 15, 2020
@OgelGames OgelGames removed the Fixed Issue has been fixed/resolved but is waiting for something or needs testing label Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Waiting ⏳ Waiting for a fix, upstream issue, or a PR to be merged
Projects
None yet
Development

No branches or pull requests

3 participants