Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light on Mars #606

Open
Emil9736 opened this issue Jan 16, 2021 · 7 comments
Open

Light on Mars #606

Emil9736 opened this issue Jan 16, 2021 · 7 comments
Labels
bug 🐛 Something isn't working Possible close

Comments

@Emil9736
Copy link

Emil9736 commented Jan 16, 2021

Command /mars_lightup dosen`t work properly. Using different types of light source has no effect.
screenshot_20210116_191952
screenshot_20210116_191834
screenshot_20210116_191852
screenshot_20210116_191922
screenshot_20210116_191946

@6r1d
Copy link

6r1d commented Jan 16, 2021

I watched the testing process. mars_lightup created a bunch of airlight nodes, then after a second or two those started disappearig very fast, as a single entity, not as independent nodes. For the context, Eula's place is close to the world border and that may or may not influence things.

For the context, I recommended adding more light to check if it'll influence current version of mars_lightup and it didn't.

@OgelGames
Copy link
Contributor

AFAIK, the way the current version is supposed to work is to place a column of airlights, and then let it spread by ABM to fill in the spaces.

There must be another ABM that is fighting against it, and winning, but the only likely one I could find was this one, which only replaces airlights near soil: https://github.com/pandorabox-io/planet_mars/blob/master/light_restore.lua#L31-L41

@OgelGames OgelGames added the bug 🐛 Something isn't working label Jan 16, 2021
@SwissalpS
Copy link
Contributor

currently disabled recalculation here

stopped placing airlights after this commit, only sets light value

currently relies on abm to place airlights.

@Emil9736
Copy link
Author

Problem continue stay actual. Command /mars_lightup have temporary effect. After few seconds light is going out.
screenshot_20210117_215607
screenshot_20210117_215617
screenshot_20210117_215548

@BuckarooBanzay
Copy link
Contributor

@Emil9736 what are doing there exactly? Some trees can reset the light-up effect, or are you just cycling dirt?

@Emil9736
Copy link
Author

Emil9736 commented Jan 17, 2021

@Emil9736 what are doing there exactly? Some trees can reset the light-up effect, or are you just cycling dirt?

BuckarooBanzay, Yes. I`m cycling dirt. There are no trees there.

@SwissalpS
Copy link
Contributor

is the problem still occuring?

somewhat related: pandorabox-io/planet_mars@20f7465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Possible close
Projects
None yet
Development

No branches or pull requests

5 participants