Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next and Previous buttons point to the right pages #108

Open
wants to merge 1 commit into
base: master
from

Conversation

@tomchop
Copy link

tomchop commented Dec 30, 2019

This fixes a bug where the Next and Previous buttons were not pointing to pages in a logical order. Hope it helps!

@tomchop tomchop requested a review from panr Jan 17, 2020
@panr

This comment has been minimized.

Copy link
Owner

panr commented Jan 23, 2020

I still don't know what's the correct order... I'd ask some of my contributors to help me choose the right one ;-)

@sophiabrandt @Rinma @kalbasit @knightjoel @seqizz what do you think?

@seqizz

This comment has been minimized.

Copy link

seqizz commented Jan 24, 2020

I'd also vote for the "older posts" has a left arrow. Just feels right, even browsers has their back button to left.

@knightjoel

This comment has been minimized.

Copy link
Contributor

knightjoel commented Jan 24, 2020

@Rinma

This comment has been minimized.

Copy link
Contributor

Rinma commented Jan 24, 2020

For me, the newest post is the first one, because it is the most relevant, and older post are on the right from it like in a book.

@tomchop

This comment has been minimized.

Copy link
Author

tomchop commented Jan 24, 2020

This was particularly striking for me since the tabs in the menu were in the /opposite/ order to which the arrows pointed in the menu. (eg. clicking on the right arrow would "move" the menu cursor one spot to the left)

@sophiabrandt

This comment has been minimized.

Copy link
Contributor

sophiabrandt commented Jan 25, 2020

An interesting discussion! I agree that it might be a matter of preference.

Imho most UIs implement it like terminal theme does it currently: the first posts are on the current window, older posts are on the right. Often there's a breadcrumb menu that shows the current window as number 1, and older posts on page 2, 3, etc.

I'd vote for not changing the arrows.

@tomchop

This comment has been minimized.

Copy link
Author

tomchop commented Jan 25, 2020

Hmm that's a good point @sophiabrandt! I had not considered the pagination or the "blogpost view". I was focusing on the "pages" rather than the list of blogposts. Let me illustrate with some screenshots:

With my changes, this is the behavior:

image
click on right arrow
image
click on right arrow
image
click on right arrow

vs. what's on master (clicking on the left arrow goes to the next item on the menu, which is on the right of the current menu, which I find pretty confusing):

image
click on left arrow
image
click on left arrow
image
click on left arrow

@sophiabrandt

This comment has been minimized.

Copy link
Contributor

sophiabrandt commented Jan 25, 2020

@tomchop I agree, for pages that makes more sense.
I'm sorry, I think I misunderstood your proposed changes.
In my opinion, the current implementation works fine for the blog posts and how they are displayed on the website.
But for the "About" section with pages I like your solution better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.