Skip to content

Add highlighting for PowerShell syntax#203

Merged
panr merged 2 commits intopanr:masterfrom
rdnlsmith:pwsh-syntax-highlight
Nov 15, 2020
Merged

Add highlighting for PowerShell syntax#203
panr merged 2 commits intopanr:masterfrom
rdnlsmith:pwsh-syntax-highlight

Conversation

@rdnlsmith
Copy link
Copy Markdown
Contributor

I believe I did this correctly. I followed the download link in the
previous prism.js, added the PowerShell checkbox, and followed the
steps in this comment; it seems to work. Unfortunately, the
minified JS diff is rather unreadable.

Fixes #193.

@panr
Copy link
Copy Markdown
Owner

panr commented Oct 31, 2020

Hi! Does this PR work for you?

Just tested it with:

```diff
-This is an old line
+This is a new line
```

and I got:

image

@rdnlsmith
Copy link
Copy Markdown
Contributor Author

This PR only adds PowerShell syntax highlighting, which was the main subject of issue #193. My comment about the diff highlighting was just an aside to ask if I had done something incorrectly; if the highlighting for diffs is actually broken, perhaps I ought to split that off into a separate issue?

@panr
Copy link
Copy Markdown
Owner

panr commented Nov 2, 2020

This PR only adds PowerShell syntax highlighting, which was the main subject of issue #193. My comment about the diff highlighting was just an aside to ask if I had done something incorrectly;

Oh, got it 👍

if the highlighting for diffs is actually broken, perhaps I ought to split that off into a separate issue?

It would be super nice!

@panr panr merged commit 29200fe into panr:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax highlighting for PowerShell

2 participants