Reorganized order of functions; etag on PUT #4

Merged
merged 7 commits into from Jan 16, 2013

Conversation

Projects
None yet
2 participants
Member

jerryblakley commented Dec 20, 2012

No description provided.

+ // We continue to PUT the file if etag happens to be NULL; it just
+ // means ultimately that it won't go into the filecache
+ if (etag) {
+ value = ne_get_response_header(req, "etag");
@davidstrauss

davidstrauss Dec 20, 2012

Owner

Is this match case-insensitive (HTTP spec says it should be, but it often isn't)?

@jerryblakley

jerryblakley Dec 20, 2012

Member

case-sensitive, I'm guessing. I tried "Etag" and "ETag" without success,
but not quite sure what to expect. I eventually called
ne_response_header_iterate just to see if anything etag-ish was even
available, and it indicated "etag" all miniscule.

On Wed, Dec 19, 2012 at 6:36 PM, David Strauss notifications@github.comwrote:

In src/ldb-filecache.c:

-int ldb_filecache_release(ldb_filecache_t *cache, const char *path, struct fuse_file_info *info) {

  • struct ldb_filecache_sdata *sdata = (struct ldb_filecache_sdata *)info->fh;

- int ret = -1;

- assert(sdata);

- log_print(LOG_DEBUG, "release(%s)", path);

  • if ((ret = ldb_filecache_sync(cache, path, info)) < 0) {
  •    log_print(LOG_ERR, "ldb_filecache_unref: ldb_filecache_sync returns error %d", ret);
    
  •    goto finish;
    
  • // We continue to PUT the file if etag happens to be NULL; it just
  • // means ultimately that it won't go into the filecache
  • if (etag) {
  •    value = ne_get_response_header(req, "etag");
    

Is this match case-insensitive (HTTP spec says it should be, but it often
isn't)?


Reply to this email directly or view it on GitHubhttps://github.com/pantheon-systems/fusedav/pull/4/files#r2473523.

@jerryblakley jerryblakley merged commit a729d7f into master Jan 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment