Fixes #1572: Disable git mode warning with configuration #1882
Conversation
| // Skip the warning for 'test' and 'live' | ||
| if (in_array($environment->id, ['test', 'live'])) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Please use $environment->isDevelopment() for this logic. It'd also be shorter if you ask
if ($environment->isDevelopment()) {
$this->validateConnectionMode($environment->get('connection_mode'));
}| @@ -120,6 +124,10 @@ protected function validateEnvironment($site, $environment) | |||
| */ | |||
| protected function validateConnectionMode($mode) | |||
| { | |||
| // Skip the warning if it is disabled | |||
| if ($this->getConfig()->get('hide_git_mode_warning')) { | |||
There was a problem hiding this comment.
I think this logic ought to apply directly to the if statement directly before the warning. If we add other outputs to this later we'll have to condense this anyway because it asks about a specific warning and this function won't necessarily always deal with this one warning.
if (!$this->getConfig()->get('hide_git_mode_warning') && ($mode === 'git')) {
$this->log()->warning(There was a problem hiding this comment.
Sure. I prefer the exit-early paradigm, but the variants you suggest are also clear and have merits as described. I'll alter as proposed.
greg-1-anderson
force-pushed
the
git-mode-warning
branch
from
a3d7229
to
e670ee2
Compare
greg-1-anderson
force-pushed
the
git-mode-warning
branch
from
f27f558
to
a5eac1b
Compare
|
At the time of this writing, GitHub is reporting that the Travis build is still waiting, but in fact the tests for this PR ran and passed at https://travis-ci.org/pantheon-systems/terminus/builds/426962621 |
|
Merged as 2fb8833 |
|
Figured out that in config.yml, instead of setting this at the command:remote:drush:options level, this works by just putting it at top level. |
No description provided.