Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Remove upstream debian packaging
  • Loading branch information
x42 committed Aug 5, 2018
1 parent d4672f5 commit ed0ac58
Show file tree
Hide file tree
Showing 11 changed files with 3 additions and 266 deletions.
37 changes: 0 additions & 37 deletions build-deb.sh

This file was deleted.

10 changes: 0 additions & 10 deletions debian/changelog

This file was deleted.

1 change: 0 additions & 1 deletion debian/compat

This file was deleted.

28 changes: 0 additions & 28 deletions debian/control

This file was deleted.

130 changes: 0 additions & 130 deletions debian/copyright

This file was deleted.

1 change: 0 additions & 1 deletion debian/docs

This file was deleted.

3 changes: 0 additions & 3 deletions debian/manpages

This file was deleted.

31 changes: 0 additions & 31 deletions debian/rules

This file was deleted.

11 changes: 0 additions & 11 deletions debian/setbfree.desktop

This file was deleted.

11 changes: 0 additions & 11 deletions debian/x42-whirl.desktop

This file was deleted.

6 changes: 3 additions & 3 deletions release.sh
Expand Up @@ -15,13 +15,13 @@ fi
echo "commit pending changes.."
git commit -a

echo "Update version number -- edit 3 files: Makefile ChangeLog debian/changelog"
echo "Update version number -- edit two files: Makefile ChangeLog"
echo -n "launch editor ? [Y/n]"
read -n1 a
echo

if test "$a" != "n" -a "$a" != "N"; then
${EDITOR} Makefile debian/changelog ChangeLog
${EDITOR} Makefile ChangeLog
fi

eval `grep "EXPORTED_VERSION=" Makefile`
Expand All @@ -42,7 +42,7 @@ make doc
make dist

echo "creating git-commit of updated doc & version number"
git commit -m "finalize changelog v${EXPORTED_VERSION}" Makefile ChangeLog debian/changelog doc/*.1
git commit -m "finalize changelog v${EXPORTED_VERSION}" Makefile ChangeLog doc/*.1

git tag "v${EXPORTED_VERSION}" || (echo -n "version tagging failed. - press Enter to continue, CTRL-C to stop."; read; )

Expand Down

3 comments on commit ed0ac58

@schnitzeltony
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a heart for packagers like me: Please reintroduce *.desktop - or is standalone no more supported?

@x42
Copy link
Collaborator Author

@x42 x42 commented on ed0ac58 Sep 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem with that is that Categories=AudioVideo;Audio; is distro-specific. Also some distros, understandably, changed the binary name to be all lower-case in /usr/bin/ and the .desktop file was invalid.

I'd rather leave it to packagers to do this correctly instead of blindly copying this from upstream.

@trebmuh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An argument for keep the desktop file in upstream source (here): so there is some issue with the categories, OK. But removing the whole file is throwing away some stuff which are great to be upstream (here) rather than done in each distribution packages (and PPA,....), such as: comments, comments translation, icons.

Could you please @x42 keep the .desktop file upstream (maybe not in a debian/ directory, but in a more general "resources" or "packaging" one) then we can try to keep consistency across distributions?

pinging @schnitzeltony

Please sign in to comment.