New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ASM6 to not fail on modules #30

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@bantonsson
Copy link
Contributor

bantonsson commented Nov 9, 2017

So this change allows jarjar to read jars and classes with Java 9 module info. It's the minimal change I needed to not fail while shading a jar with Java 9 module info in it.

@stuhood stuhood self-requested a review Nov 9, 2017

@stuhood

stuhood approved these changes Nov 9, 2017

Copy link
Member

stuhood left a comment

Thanks!

Will incorporate into pantsbuild/pants later today.

@stuhood stuhood merged commit 31dae5b into pantsbuild:master Nov 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit to twitter/pants that referenced this pull request Nov 9, 2017

stuhood added a commit to pantsbuild/pants that referenced this pull request Nov 9, 2017

Bump to jarjar 1.6.5 to pull in pantsbuild/jarjar#30 (#5087)
### Problem

As described on pantsbuild/jarjar#30, the version of ASM in use in jarjar did not support JDK9 modules.

### Solution

Update to a version of jarjar that includes pantsbuild/jarjar#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment