From 2ee9b426d510fb5c1d7d8cb306c693fbefd4c397 Mon Sep 17 00:00:00 2001 From: Mathieu Sabourin Date: Sat, 10 Nov 2018 07:53:58 -0800 Subject: [PATCH] Fix Python 3 option integration test issue with unicode (#6755) --- build-support/known_py3_integration_failures.txt | 1 - tests/python/pants_test/option/test_quiet_option_integration.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/build-support/known_py3_integration_failures.txt b/build-support/known_py3_integration_failures.txt index 186cad3eef2..86b847f92aa 100644 --- a/build-support/known_py3_integration_failures.txt +++ b/build-support/known_py3_integration_failures.txt @@ -3,6 +3,5 @@ tests/python/pants_test/backend/jvm/tasks:checkstyle_integration tests/python/pants_test/backend/python/tasks:integration tests/python/pants_test/backend/python/tasks:python_native_code_testing tests/python/pants_test/engine/legacy:pants_engine_integration -tests/python/pants_test/option:options_integration tests/python/pants_test/pantsd:pantsd_integration tests/python/pants_test/projects:testprojects_integration diff --git a/tests/python/pants_test/option/test_quiet_option_integration.py b/tests/python/pants_test/option/test_quiet_option_integration.py index 147c0263c57..3fa69711a36 100644 --- a/tests/python/pants_test/option/test_quiet_option_integration.py +++ b/tests/python/pants_test/option/test_quiet_option_integration.py @@ -37,7 +37,7 @@ def test_pants_no_quiet_output_file(self): pants_run = self.run_pants(['--no-quiet', 'export', '--output-file={}'.format(f.name)]) self.assert_success(pants_run) - json_string = f.read() + json_string = f.read().decode('utf8') # Make sure the json is valid from the file read. json.loads(json_string) # Make sure json string does not appear in stdout.